[FFmpeg-devel] [RFC] Make swscale-test perform only one convertion

Ramiro Polla ramiro.polla
Thu Feb 18 05:25:39 CET 2010


On Wed, Feb 17, 2010 at 9:52 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Tuesday 2010-02-16 20:27:33 +0100, Michael Niedermayer encoded:
>> On Tue, Feb 16, 2010 at 01:29:02AM +0100, Stefano Sabatini wrote:
>> > On date Friday 2010-02-12 01:30:23 +0100, Michael Niedermayer encoded:
>> > > On Fri, Feb 12, 2010 at 12:32:44AM +0100, Stefano Sabatini wrote:
>> > > [...]
>> > > > + ? ?if (((i = 1) && ((srcFmt = av_get_pix_fmt(argv[i])) == PIX_FMT_NONE)) ||
>> > > > + ? ? ? ?((i = 2) && ((dstFmt = av_get_pix_fmt(argv[i])) == PIX_FMT_NONE))) {
>> > > > + ? ? ? ?fprintf(stderr, "Unknown pixel format name: '%s'\n", argv[i]);
>> > > > + ? ? ? ?return -1;
>> > > > + ? ?}
>> > >
>> > > wrong mailing list, this is not the obfuscated code contest
>> >
>> > Uh, maybe I overdid at trying to keep low the line count...
>> >
>> > Regards.
>> > --
>> > FFmpeg = Fancy & Furious Moronic Pacific Extravagant Geek
>>
>> > ?swscale-test-all.sh | ? 11 +++++++++++
>> > ?swscale-test.c ? ? ?| ? 36 +++++++++++++++++++-----------------
>> > ?2 files changed, 30 insertions(+), 17 deletions(-)
>> > 1766e975f79d21a0b4c898fe8f41c4d2f1e8a615 ?implement-swscale-test-lite.patch
>>
>> I think we should wait until we have a benchmark on mingw
>> or reduce the amount of shell work aka use C instead
>
> Ramiro can you provide a benchmark on MinGW?

swscale-test is currently crashing in Windows in ./swscale-test.exe
rgb24 argb. Apparently due to heap corruption (that's what windows
says), but I couldn't find out the exact cause yet.

> Also my gut feeling is that we should use shell when meaningful and
> make pression to get things improved at the root of the problem (which
> is MinGW in this case).

The problem is windows slow at launching processes.

By the way is this intended to work out-of-tree?

Ramiro Polla



More information about the ffmpeg-devel mailing list