[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Mohamed Naufal]

On 15 January 2010 05:41, Michael Niedermayer <michaelni at gmx.at> wrote:


[...]


> > +typedef struct YopDecContext {
> > +    AVFrame frame;
> > +    AVCodecContext *avctx;
> > +    AVPacket *avpkt;
> > +
> > +    int num_pal_colors;
> > +    int first_color[2];
> > +    int tag_needs_next_byte;
>
> > +    int current_tag_byte;
>
> you dont need that variable
>

If I don't increment s->srcptr in the if block of yop_get_next_nibble(),
color_num in yop_paint_block() can have an incorrect value.

[...]


> > +/**
> > + * Update the palette based on the frame number. Consume all of the
> palette
> > + * bytes on the input.
> > + */
> > +static void yop_update_palette(YopDecContext *s)
> > +{
> > +    int firstcolor;
> > +    int i, j;
> > +
> > +    firstcolor = s->first_color[s->avctx->frame_number & 1];
>
> this will be wrong with seeking id suspect
>


How else do I do it?

Couldn't post earlier. My laptop got stolen :(

Naufal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yop.patch
Type: text/x-patch
Size: 19294 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100218/fde50e66/attachment.bin>