[FFmpeg-devel] [PATCH] Remove final semicolons from get_bits macros

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Feb 21, 2010 at 01:19:16AM +0000, M?ns Rullg?rd wrote:
>> Mans Rullgard <mans at mansr.com> writes:
>> 
>> > Some of the macros in get_bits.h include a final semicolon.  This
>> > removes them and adds semicolons as necessary where these macros
>> > are invoked.
>> >
>> > Tested with all three readers.
>> > ---
>> >  libavcodec/get_bits.h |  118 ++++++++++++++++++++++++------------------------
>> >  libavcodec/mjpegdec.c |   24 +++++-----
>> >  2 files changed, 71 insertions(+), 71 deletions(-)
>> 
>> ping
>
> I prefer them with the semicolons as they are
> They are blocks of code not single statements
> This of course is arguably a bikeshed issue but to me
>
> if(X)
>     MAKRO()
>
> reminds me that i forgot something
> while
>
> if(X)
>     MAKRO();
>
> looks like a function call
> and then someone will argue that we need
> do{
> }while(0)

Which we should, dammit.

I've tripped over those bizarre semicolons of yours too many times.

-- 
M?ns Rullg?rd
mans at mansr.com