[FFmpeg-devel] [PATCH] asfenc: fix extended content header

Anton Khirnov wyskas
Sun Feb 21 15:54:40 CET 2010


On Sun, Feb 21, 2010 at 01:34:14PM +0100, Michael Niedermayer wrote:
> 
> the patch replaces if() by switch/case
> the patch fixes a memleak by adding av_free (should be av_freep)
> it adds an av_log()
> and it drops handling of the byte array case
> 
> i guess you should send 4 patches, this would avoid misundderstandings
> (if->switch rejected)
> (av_log needs +1 line)
> (av_free needs +1 line)
> (byte arary change +0 line)
> 
switch looked nicer to me, but whatever. fixed and split

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-asfdec-only-unicode-tags-must-have-even-length.patch
Type: text/x-diff
Size: 928 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/9243707c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-asfdec-fix-a-memleak.patch
Type: text/x-diff
Size: 707 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/9243707c/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-asfdec-add-a-debug-message-about-skipped-tags.patch
Type: text/x-diff
Size: 772 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/9243707c/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-asfdec-skip-byte-array-tags.patch
Type: text/x-diff
Size: 971 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/9243707c/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/9243707c/attachment.pgp>



More information about the ffmpeg-devel mailing list