[FFmpeg-devel] [PATCH/RFC] Constify src in av_fifo_generic_write()

Tomas Härdin tomas.hardin
Wed Feb 24 10:31:12 CET 2010


On Wed, 2010-02-24 at 10:06 +0100, Stefano Sabatini wrote:
> On date Wednesday 2010-02-24 08:46:22 +0100, Tomas H?rdin encoded:
> [...]
> > Index: libavutil/fifo.h
> > ===================================================================
> > --- libavutil/fifo.h	(revision 22019)
> > +++ libavutil/fifo.h	(working copy)
> > @@ -81,7 +81,7 @@
> >  /**
> >   * Feeds data from a user-supplied callback to an AVFifoBuffer.
> >   * @param *f AVFifoBuffer to write to
> > - * @param *src data source
> > + * @param *src data source; non-const since it may be used as a modifiable context in func
> 
> Please no abbreviations in doxy, and which is the function referred
> to?
> 
> Regards.

"func" is another parameter, defined just a few lines down. Perhaps I
should add quotes around the name though. See attached patch.

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fifo_h_const_doc2.patch
Type: text/x-patch
Size: 581 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100224/816d0685/attachment.bin>



More information about the ffmpeg-devel mailing list