[FFmpeg-devel] [PATCH] Fix NV12/NV21 planarCopy()

Gwenole Beauchesne gbeauchesne
Thu Feb 25 09:25:22 CET 2010


On Sun, 21 Feb 2010, Michael Niedermayer wrote:

>> @@ -1613,8 +1613,8 @@
>>
>>          if (!dst[plane]) continue;
>>          // ignore palette for GRAY8
>> -        if (plane == 1 && !dst[2]) continue;
>> -        if (!src[plane] || (plane == 1 && !src[2])) {
>> +        if (c->dstFormat == PIX_FMT_GRAY8 && plane == 1 && !dst[2]) continue;
>> +        if (!src[plane] || (c->srcFormat == PIX_FMT_GRAY8 && plane == 1 && !src[2])) {
>
> a check based on isInterleavedUV() or usePal() seems better to me

Should the comment be changed then? Since it related to GRAY8, I simply 
thought it would be better to check for GRAY8 format explicitly.



More information about the ffmpeg-devel mailing list