[FFmpeg-devel] [PATCH] Fix NV12/NV21 planarCopy()

[Michael Niedermayer]

On Thu, Feb 25, 2010 at 09:25:22AM +0100, Gwenole Beauchesne wrote:
> On Sun, 21 Feb 2010, Michael Niedermayer wrote:
>
>>> @@ -1613,8 +1613,8 @@
>>>
>>>          if (!dst[plane]) continue;
>>>          // ignore palette for GRAY8
>>> -        if (plane == 1 && !dst[2]) continue;
>>> -        if (!src[plane] || (plane == 1 && !src[2])) {
>>> +        if (c->dstFormat == PIX_FMT_GRAY8 && plane == 1 && !dst[2]) 
>>> continue;
>>> +        if (!src[plane] || (c->srcFormat == PIX_FMT_GRAY8 && plane == 1 
>>> && !src[2])) {
>>
>> a check based on isInterleavedUV() or usePal() seems better to me
>
> Should the comment be changed then? Since it related to GRAY8, I simply 

maybe

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100225/1f0a3d60/attachment.pgp>