[FFmpeg-devel] [PATCH] HE-AAC v1 decoder try 4

Michael Niedermayer michaelni
Fri Feb 26 15:29:41 CET 2010


On Fri, Feb 26, 2010 at 12:36:53AM -0500, Alex Converse wrote:
> On Wed, Feb 24, 2010 at 11:06 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > On Wed, Feb 24, 2010 at 10:31:43PM -0500, Alex Converse wrote:
> > > On Wed, Feb 24, 2010 at 9:20 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > > On Wed, Feb 24, 2010 at 07:36:53PM -0500, Alex Converse wrote:
> > > >> On Tue, Feb 16, 2010 at 6:19 PM, Alex Converse <alex.converse at gmail.com> wrote:
> > > >> > On Tue, Feb 16, 2010 at 6:01 PM, Alex Converse <alex.converse at gmail.com>
> > > >> > wrote:
> > > >> >>
> > > >> >> Notes:
> > > >> >> *All the computation time is spent in ff_sbr_apply() and it's
> > > >> >> children. If it isn't called from ff_sbr_apply() making it 100% faster
> > > >> >> isn't going to buy us anything.
> > > >> >> *Right now the synthesis filterbank is written on top on an MDCT. With
> > > >> >> appropriate SIMD functions it may make sense to move it to an FFT.
> > > >> >> Right now the MDCT version is much faster.
> > > >> >> *SIMD placeholder patch not included
> > > >> >
> > > >> > Wrong patch.
> > > >> > try 4.1 :)
> > > >>
> > > >> Since the last patch I beat on the decoder with the zzuf hammer and
> > > >> fixed a few minor things as well as addressing the feeback I've seen
> > > >> in this thread.
> > > >>
> > > >> So I'm trying to figure out where we stand on this:
> > > >> *Does the ffplay issue block this?
> > > >
> > > > what ffplay issue?
> > > >
> > >
> > > The sample rate gets set late and ffplay winds up playing back at its
> > > default sample rate, as discovered by Vlad earlier in this thread.
> >
> > id say move the sample_rate=0 from the codec init to av_find_stream_info()
> > that is
> > if(aac) sample_rate=0; //elaborate comment
> >
> That still passes a zero to ffplay, unless you mean to do that before
> the has_codec_parameters() check

i of course meant at the top of av_find_stream_info() not in the loop


>  in which case I think B below is
> cleaner.

B will break all network/realtime streams, that is they will take
a long time before av_find_stream_info() finally fails without having
found all parameters

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100226/44f5875c/attachment.pgp>



More information about the ffmpeg-devel mailing list