[FFmpeg-devel] [RFC] libavformat: URL reassembly with IPv6 addresses

Ronald S. Bultje rsbultje
Sat Feb 27 00:33:28 CET 2010


Hi,

On Fri, Feb 26, 2010 at 5:09 PM, Martin Storsj? <martin at martin.st> wrote:
> Ok, so based on this discussion, here's another suggestion. One function
> that hides all the details of escaping IP addresses in URLs and assembling
> URLs, which is quite simple and non-intrusive to use. All the code that
> uses it is left as simple as before, or even becomes simpler.

I like. Would like comments from others (Michael, Lucas).

> +    if (authorization)
> +        av_strlcatf(str, size, "%s:", authorization);

@, not :

> +#endif
> +    {
> +        /* Not an IPv6 address, just output the plain string. */
> +        av_strlcat(str, hostname, size);
> +    }

Superfluous {}.

Ronald



More information about the ffmpeg-devel mailing list