[FFmpeg-devel] [PATCH]ffmpeg.c: add option for copying chapters

[Michael Niedermayer]

On Sat, Feb 27, 2010 at 07:10:02PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 27, 2010 at 08:18:12AM +0100, Anton Khirnov wrote:
> > On Fri, Feb 26, 2010 at 12:00:03AM +0100, Michael Niedermayer wrote:
> > > On Thu, Feb 25, 2010 at 09:11:24PM +0100, Anton Khirnov wrote:
> > > > On Thu, Feb 25, 2010 at 05:28:22PM +0100, Michael Niedermayer wrote:
> > > > > On Thu, Feb 25, 2010 at 04:05:33PM +0100, Anton Khirnov wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > $subj
> > > > > > 
> > > > > > Anton Khirnov
> > > > > 
> > > > > >  doc/ffmpeg-doc.texi |    3 ++
> > > > > >  ffmpeg.c            |   78 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> > > > > >  2 files changed, 80 insertions(+), 1 deletion(-)
> > > > > > 6365bd394dd3a804132673b6d607cd25c864a6a9  0001-ffmpeg.c-add-map_chapters-option-for-copying-chapter.patch
> > > > > > From 875650637e70521632526f8776697fe3d6f02dcc Mon Sep 17 00:00:00 2001
> > > > > > From: Anton Khirnov <wyskas at gmail.com>
> > > > > > Date: Wed, 24 Feb 2010 23:00:31 +0100
> > > > > > Subject: [PATCH] ffmpeg.c: add -map_chapters option for copying chapters.
> > > > > 
> > > > > usfull but shouldnt we first by default copy chapters from input to
> > > > > output file? (that is the parts that are within start-end time ?
> > > > how would ffmpeg decide from which input file to which output file
> > > > should it copy? i don't think it should try to be overly smart here.
> > > > we don't copy metadata by default either.
> > > 
> > > i think we should copy metadata & chapters for 1 file in, 1 out
> > > for the 2 files in 1 file out, AVStream based metadata could still be copied
> > > 
> > > i dont see a problem wth this, but maybe you have some issues in mind
> > > where this would be unwanted ?
> 
> > not real issues, i just don't like the idea that with one input file
> > ffmpeg does copy metadata/chapters, but with two it suddenly doesn't.
> 
> it could copy to AVStream metadata

it also could copy chapters from both
in which case does this break?
you copying the video from the matrix together with the audio from
terminator 2 ;)
that will be a odd thing to watch and i wouldnt consider having chapters
from both mixed to be that wrong in this case ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100227/8d67c88c/attachment.pgp>