[FFmpeg-devel] [PATCH] Make lsws expose supported formats

Stefano Sabatini stefano.sabatini-lala
Sun Jan 3 00:48:33 CET 2010


On date Saturday 2010-01-02 13:56:14 +0100, Stefano Sabatini encoded:
> Hi, as in subject.
> 
> Maybe a better solution would be to replace the macros with
> corresponding functions.
> 
> Regards.
> -- 
> FFmpeg = Furious and Faboulous Minimal Porno Evanescent Generator

> Index: ffmpeg/libswscale/swscale.c
> ===================================================================
> --- ffmpeg.orig/libswscale/swscale.c	2010-01-02 13:52:47.000000000 +0100
> +++ ffmpeg/libswscale/swscale.c	2010-01-02 13:54:54.000000000 +0100
> @@ -158,6 +158,11 @@
>          || (x)==PIX_FMT_YUV444P16BE   \
>      )
>  
> +int sws_is_input_supported(enum PixelFormat pix_fmt)

Sorry to bother but I feel unsatisfied with the name, I don't like the
interrogative form, I tend to prefer:

sws_input_is_supported(pix_fmt) -> pix_fmt input is supported
or even:
sws_is_supported_input(pix_fmt) -> pix_fmt is a supported input
maybe sounds better.

Or maybe:
sws_inputIsSupported() or sws_isSupportedInput()

to make it consistent with the camelCasing used in libswscale.

What do you guys suggest?

Regards.
-- 
FFmpeg = Faithless and Faboulous Moronic Philosofic Extensive Game



More information about the ffmpeg-devel mailing list