[FFmpeg-devel] [PATCH] restore old buffer content when http seek fails

Ronald S. Bultje rsbultje
Wed Jan 6 23:43:55 CET 2010


Hi Baptiste,

On Wed, Jan 6, 2010 at 5:29 PM, Baptiste Coudurier
<baptiste.coudurier at gmail.com> wrote:
> On 01/06/2010 02:26 PM, Ronald S. Bultje wrote:
>> On Mon, Jan 4, 2010 at 9:48 PM, Baptiste Coudurier
>> <baptiste.coudurier at gmail.com> ?wrote:
>>> $subject. Fixes issue #1631
>>
>> Thanks for fixing this. Can we do this without the memcpy()s? If not,
>> patch ok.
>
> Do you have an idea ?
> http protocol currently uses s->buffer in the http_connect and http_getc, I
> tried to change that unsuccessfully.

I guess it'd require some refactoring. Patch is OK then (BUFFER_SIZE
is small anyway), I'll try to refactor that later.

I'd be interested in profiling stats for different values of
BUFFER_SIZE, my guess is it'd work better if we'd set it to 256-512.

Ronald



More information about the ffmpeg-devel mailing list