[FFmpeg-devel] [PATCH 2/2] Add SIPR decoder for 5k0, 6k5 and 8k5 modes
Vitor Sessak
vitor1001
Fri Jan 8 14:09:32 CET 2010
Ronald S. Bultje wrote:
> Hi Vitor,
>
> On Jan 7, 2010, at 10:23 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>> in: { 2, 2.2, 7, 9.5, 10 }
>> out: { 2, 4, 7, 9.5, 10 }
>> ff_acelp_reorder_lsf(): { 2, 4, 7, 9.5, 11.5}
>> sane: { 2, 4, 7, 9.5, 11.5}
>>
>> here we see a problem
>
> Ah, I see what you mean, min_dist is not enforced for the last lsf. Very
> interesting. For WMAVoice, that's not the case, it's exactly like the
> int version. OK, I guess that makes the discussion moot then.
>
> Does output quality audibly differ when adding in this "feature"? (It
> might just be a decoder bug, WMAVoice is full of them.) Deviating from
> binary can sometimes be OK...
>
> If the output doesn't change or worsens, patch OK (but please explain
> this difference in a doxy); if it improves, it might be worth using that
> instead.
No, the output gets completely garbled if I do like in
ff_acelp_reorder_lsf().
Does anyone else wants to comment/review this codec? If nobody comment
in a couple of days I'll commit it.
-Vitor
More information about the ffmpeg-devel
mailing list