[FFmpeg-devel] [PATCH 2/2] Rename log2/exp2 replacements ff_log2/ff_exp2

[Måns Rullgård]

Alex Converse <alex.converse at gmail.com> writes:

> 2010/1/12 M?ns Rullg?rd <mans at mansr.com>
>>
>> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>>
>> > Hi,
>> >
>> > On Tue, Jan 12, 2010 at 10:55 AM, Mans Rullgard <mans at mansr.com> wrote:
>> >> This avoids conflicts with system headers on broken platforms.
>> >
>> > I don't think this is right, you're essentially duplicating system
>> > functions for the sake of broken systems, but you do so even on
>> > non-broken ones.
>>
>> No, I'm not.
>>
>> > I like Vitor's approach better...
>>
>> I have the feeling that *any* attempt to provide replacements with the
>> real names will break in some way or other.
>
> At a certain point I think you let people who run broken platforms
> work together to contribute a fix that doesn't negatively impact
> platforms that made a reasonable effort to implement a standard
> library that is from the 1990s.

You and I both know that's not going to happen.  We have two options:
1) drop support for those broken platforms, or 2) work around the
problems ourselves.

I'm usually against local workarounds, but sometimes they are the only
viable alternative.  In this particular case, we have so many
different types of breakage that any replacement is likely to conflict
with at least one of them.

-- 
M?ns Rullg?rd
mans at mansr.com