[FFmpeg-devel] [PATCH] Fix function parameters for rgb48 to YV12 functions.

[Ramiro Polla]

On Mon, Jan 11, 2010 at 12:51 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Jan 11, 2010 at 05:21:19AM -0200, Ramiro Polla wrote:
>> $subj
>
>> ?swscale.c | ? ?9 ++++++---
>> ?1 file changed, 6 insertions(+), 3 deletions(-)
>> cf0e5d1b0d322cac274144c19a6842deaab35f06 ?0001-Add-missing-parameter-to-rgb48-to-YV12-functions.patch
>> From ddf2d2f6f79556d0b65e2657772f42963b35d602 Mon Sep 17 00:00:00 2001
>> From: Ramiro Polla <ramiro.polla at gmail.com>
>> Date: Mon, 11 Jan 2010 05:00:38 -0200
>> Subject: [PATCH] Add missing parameter to rgb48 to YV12 functions.
>
> ok

Applied.

>> ?swscale.c | ? ?8 ++++----
>> ?1 file changed, 4 insertions(+), 4 deletions(-)
>> 89382350eded6c26d436823cd03024fe8a5b7fdc ?0002-Add-const-qualifier-to-rgb48-to-YV12-functions-src.patch
>> From 995f52a73adc9b7b66453d20405cc37094a94314 Mon Sep 17 00:00:00 2001
>> From: Ramiro Polla <ramiro.polla at gmail.com>
>> Date: Mon, 11 Jan 2010 05:02:44 -0200
>> Subject: [PATCH] Add const qualifier to rgb48 to YV12 functions' src.
>
> ok

Applied.

>> ?swscale.c | ? ?6 +++---
>> ?1 file changed, 3 insertions(+), 3 deletions(-)
>> 104e7c17caec26638ce07bb04dc15eaa0d9133fb ?0003-int-long-for-width-parameter-in-rgb48-to-YV12-fun.patch
>> From da0f8f381054f23a32251981354ec56fb1232a56 Mon Sep 17 00:00:00 2001
>> From: Ramiro Polla <ramiro.polla at gmail.com>
>> Date: Mon, 11 Jan 2010 05:04:09 -0200
>> Subject: [PATCH] int -> long for width parameter in rgb48 to YV12 functions.
>
> dont we have a proper type for that?

You mean x86_reg? That wouldn't be nice in a function declaration.

What I have in mind now is changing them all to int, and cast to
x86_reg (or use local x86_reg variables) only inside x86 or mmx
ifdefs. What do you think about this approach?

> also these unused vars could need a av_unused

The ones in the function declaration? Does it make any difference?