[FFmpeg-devel] [PATCH] Fix warning in av_rescale_rnd (in libavutil/mathematics.c)

[Michael Niedermayer]

On Sat, Jul 03, 2010 at 12:42:08AM -0700, Eli Friedman wrote:
> Patch attached.  Fixes warning "comparison of unsigned expression >= 0
> is always true".

god damn, its a assert(), what is wrong with asserting that a variable
is unsigned or if signed is positive. Why is gcc so retarded
your changed code does not check for that anymore and actually your code
is worse than removing the assert. Try to understand why its there like
that please!
we dont check for symbolic enum values we require specific nummeric
values, we must assert on nummeric properties thus.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100703/05f8097e/attachment.pgp>