[FFmpeg-devel] [PATCH] Unconditionally run emms on calls to emms_c() if HAVE_MMX is defined

Måns Rullgård mans
Sun Jul 4 17:05:26 CEST 2010


Eli Friedman <eli.friedman at gmail.com> writes:

> 2010/7/4 M?ns Rullg?rd <mans at mansr.com>:
>> Eli Friedman <eli.friedman at gmail.com> writes:
>>
>>> On Sat, Jul 3, 2010 at 11:50 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>>>> Patch attached. ?We already assume HAVE_MMX implies MMX is available
>>>> at runtime, so this seems like it should be OK.
>>>
>>> Actually, that's wrong... I think this breaks distros that want to
>>> support Pentium Pro and earlier in the same binary for modern
>>> computers.
>>
>> A binary built for i586 or earlier will be quite crippled even in
>> plain C code. ?The only sane thing to do as a distro to provide two
>> packages (or more).
>
> So you think this patch is okay?

_I_ think the idea is OK, but your patch isn't quite what I intended.
I'm waiting for Reinhard to voice his opinion.  He knows what distros
want, can, and can't.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list