[FFmpeg-devel] [PATCH] Add #ifdefs around code specific to file and pipe protocols

Måns Rullgård mans
Tue Jul 6 15:17:33 CEST 2010


Michael Niedermayer <michaelni at gmx.at> writes:

> On Tue, Jul 06, 2010 at 02:02:33PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Tue, Jul 06, 2010 at 12:59:57AM +0100, Mans Rullgard wrote:
>> >> ---
>> >>  libavformat/file.c |   42 ++++++++++++++++++++++++------------------
>> >>  1 files changed, 24 insertions(+), 18 deletions(-)
>> >
>> > more ifdefery is not good
>> > so why?
>> 
>> So the protocols can be individually disabled should someone so
>> desire.  Where is the harm in that?  Then again, it doesn't do much
>> harm as is, so I'll drop the change.
>
> no, patch ok in that case

To clarify, both protocols are currently built (but not registered) if
either of them is enabled.  They are in the same file because they
share the read/write functions.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list