[FFmpeg-devel] [implement-pixdesctest PATCH] Rename read_line() and write_line() to av_read_image_data_line and av_write_image_data_line().

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Wednesday 2010-07-07 22:41:27 +0100, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> 
>> > The old names were not av_ prefixed, and they were causing linking
>> > failure on many platforms.
>> > ---
>> >  libavfilter/vf_pixdesctest.c |    4 ++--
>> >  libavutil/pixdesc.c          |    4 ++--
>> >  libavutil/pixdesc.h          |    8 ++++----
>> >  3 files changed, 8 insertions(+), 8 deletions(-)
>> >
>> > diff --git a/libavfilter/vf_pixdesctest.c b/libavfilter/vf_pixdesctest.c
>> > index 871be30..3c1dab3 100644
>> > --- a/libavfilter/vf_pixdesctest.c
>> > +++ b/libavfilter/vf_pixdesctest.c
>> > @@ -90,13 +90,13 @@ static void draw_slice(AVFilterLink *inlink, int y, int h, int slice_dir)
>> >          int y1 = c == 1 || c == 2 ? y>>priv->pix_desc->log2_chroma_h : y;
>> >
>> >          for (i = y1; i < y1 + h1; i++) {
>> > -            read_line(priv->line,
>> > +            av_read_image_data_line(priv->line,
>> 
>> New name seems a bit long.  What would you read/write if not data?
>
> av_read_image_line
> av_write_image_line 
>
> sounds good to me.
>
> "picture" in place of "image" may be preferred (more consistent with
> the avpicture* lavc functions).
>
> Note that this is technically breaking ABI/API, we can consider it a
> bugfix or introduce a backward compatibility layer, since as it is is
> currently broken on half platforms, the latter looks overkill to me.

I'd bump minor version and worry no further about it.  If someone
insists, add a couple of #defines under #if MAJOR < xx.

-- 
M?ns Rullg?rd
mans at mansr.com