[FFmpeg-devel] [PATCH] move put_v from nutenc.c and make it public in avio.h and aviobuf.c

Michael Niedermayer michaelni
Thu Jul 8 01:06:15 CEST 2010


On Wed, Jul 07, 2010 at 11:00:56PM +0100, M?ns Rullg?rd wrote:
> Michael Chinen <mchinen at gmail.com> writes:
> 
> > --- a/libavformat/avio.h
> > +++ b/libavformat/avio.h
> > @@ -352,12 +352,12 @@ void put_strz(ByteIOContext *s, const char *buf);
> >  /**
> >   * Put val using a variable number of bytes.
> >   */
> > -void put_v(ByteIOContext *bc, uint64_t val);
> > +void ff_put_v(ByteIOContext *bc, uint64_t val);
> >  
> >  /**
> >   * Get the length in bytes which is needed to store val as v.
> >   */
> > -int get_length(uint64_t val);
> > +int ff_get_v_length(uint64_t val);
> 
> Since this is a public header, wouldn't an av_ prefix be appropriate?

i dont think we are planing to use them from outside lavf so it should be ff_
the header is maybe not the best place though

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100708/3178155a/attachment.pgp>



More information about the ffmpeg-devel mailing list