[FFmpeg-devel] [PATCH] Add a MAXDIST parameter to tiny_psnr (for 1-off fate tests)

Ronald S. Bultje rsbultje
Thu Jul 8 20:51:02 CEST 2010


Hi,

On Thu, Jul 8, 2010 at 2:47 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> $subj, it is necessary to get FATE to test float-based codecs (at least
> locally through "make fate") by checking if MAXDIST == 1. Comments are
> welcome.
[..]
> +            dist = a-b;
> +            dist = dist < 0 ? -dist : dist;

FFABS().

More importantly, I don't think this is right, we should normalize it
to the total signal, e.g. FFABS(a-b)/(FFABS(a)+FFABS(b)) or something
along those lines.

Ronald



More information about the ffmpeg-devel mailing list