[FFmpeg-devel] [PATCH] move put_v from nutenc.c and make it public in avio.h and aviobuf.c

[Michael Chinen]

On Thu, Jul 8, 2010 at 2:53 AM, Michael Chinen <mchinen at gmail.com> wrote:
> 2010/7/8 M?ns Rullg?rd <mans at mansr.com>:
>> Michael Chinen <mchinen at gmail.com> writes:
>>> 2010/7/8 M?ns Rullg?rd <mans at mansr.com>:
>>> Ok. ?To be clear, private here means ff_ prefix in avio.h?
>>
>> No, it means ff_ prefix in some private header. ?avio.h is a public
>> header, so it's a bad place for private stuff.
> I understand now. ?I thought maybe there was some convention where ff_
> and non-av_ prefixes in public headers meant clients shouldn't use
> those and pretend they were private.
>
> I see the logic but want to note this will create some inconsistency
> since the read counterpart for these functions (ff_get_v) is already
> public in avio.h. ? If this is okay I'll put ff_put_v and
> ff_get_v_length in internal.h/aviobuf.c. ?On the other hand if we want
> to make them public I accidentally made the patches :)

I didn't hear anything back so here are the patches to do put ff_put_v
into internal.h/aviobuf.c.
Let me know if you want to see the public header patch.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rename-get_length-to-ff_get_v_length-and-put_v-to-ff.patch
Type: application/octet-stream
Size: 11395 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100709/ec306311/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-moving-ff_get_v_length-and-ff_put_v-from-nutenc.c-to.patch
Type: application/octet-stream
Size: 2682 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100709/ec306311/attachment-0001.obj>