[FFmpeg-devel] [PATCH] move put_v from nutenc.c and make it public in avio.h and aviobuf.c

[Michael Niedermayer]

On Fri, Jul 09, 2010 at 01:08:07AM +0200, Michael Chinen wrote:
> On Thu, Jul 8, 2010 at 2:53 AM, Michael Chinen <mchinen at gmail.com> wrote:
> > 2010/7/8 M?ns Rullg?rd <mans at mansr.com>:
> >> Michael Chinen <mchinen at gmail.com> writes:
> >>> 2010/7/8 M?ns Rullg?rd <mans at mansr.com>:
> >>> Ok. ?To be clear, private here means ff_ prefix in avio.h?
> >>
> >> No, it means ff_ prefix in some private header. ?avio.h is a public
> >> header, so it's a bad place for private stuff.
> > I understand now. ?I thought maybe there was some convention where ff_
> > and non-av_ prefixes in public headers meant clients shouldn't use
> > those and pretend they were private.
> >
> > I see the logic but want to note this will create some inconsistency
> > since the read counterpart for these functions (ff_get_v) is already
> > public in avio.h. ? If this is okay I'll put ff_put_v and
> > ff_get_v_length in internal.h/aviobuf.c. ?On the other hand if we want
> > to make them public I accidentally made the patches :)
> 
> I didn't hear anything back so here are the patches to do put ff_put_v
> into internal.h/aviobuf.c.
> Let me know if you want to see the public header patch.
> 
> Michael

>  nutenc.c |  136 +++++++++++++++++++++++++++++++--------------------------------
>  1 file changed, 68 insertions(+), 68 deletions(-)
> 7fcc0b0582794ccb8a54c0e204f0931a387f67e5  0001-rename-get_length-to-ff_get_v_length-and-put_v-to-ff.patch
> From 56fa5a75b2c415ce1604883f33fe2d3ce576d199 Mon Sep 17 00:00:00 2001
> From: Michael Chinen <mchinen at gmail.com>
> Date: Fri, 9 Jul 2010 00:51:10 +0200
> Subject: [PATCH 1/2] rename get_length to ff_get_v_length and put_v to ff_put_v
[...]

>  aviobuf.c  |   19 +++++++++++++++++++
>  internal.h |   10 ++++++++++
>  nutenc.c   |   21 ---------------------
>  3 files changed, 29 insertions(+), 21 deletions(-)
> bacfd4ce242848613ccc5912cd267f6503d3a84b  0002-moving-ff_get_v_length-and-ff_put_v-from-nutenc.c-to.patch
> From 61fcab2672ad2f3471e3737f0d0ce27c744384eb Mon Sep 17 00:00:00 2001
> From: Michael Chinen <mchinen at gmail.com>
> Date: Fri, 9 Jul 2010 00:59:32 +0200
> Subject: [PATCH 2/2] moving ff_get_v_length and ff_put_v from nutenc.c to internal.h/aviobuf.c

patches look ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100709/a690be31/attachment.pgp>