[FFmpeg-devel] [PATCH]Use CONFIG_LIBXVID_ENCODER in ratecontrol.c

Måns Rullgård mans
Fri Jul 9 12:41:44 CEST 2010


Diego Biurrun <diego at biurrun.de> writes:

> On Fri, Jul 09, 2010 at 11:07:37AM +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Fri, Jul 09, 2010 at 11:13:10AM +0200, Carl Eugen Hoyos wrote:
>> >> 
>> >> Is this patch (that fixes an MPlayer linking problem) acceptable?
>> >
>> > Looks OK to me.
>> 
>> Not to me.
>
> I just checked that ratecontrol.c is only ever used by encoders, so I do
> not see how the patch can do any harm...

It is wrong, plain and simple.  CONFIG_LIBXVID_ENCODER means the user
requested the -vcodec libxvid wrapper.  The libxvid RC is separate
from that.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list