[FFmpeg-devel] [PATCH 2/2] Fix side channels when XCh extension is present

Benoit Fouet benoit.fouet
Mon Jul 12 14:32:40 CEST 2010


On Mon, 12 Jul 2010 12:24:24 +0200 Benjamin Larsson wrote:
> Christophe Gisquet skrev 2010-07-12 11:27:
> > Hi,
> >
> > 2010/7/11 Kostya<kostya.shishkov at gmail.com>:
> >    
> >>>>                  lt_chan[j] -= (back_chan[j] - s->add_bias) * 0.707107f;
> >>>>                  rt_chan[j] -= (back_chan[j] - s->add_bias) * 0.707107f;
> >>>>          
> > As this magic value is in fact a coarse rounding (maybe it is mandated
> > by the spec?) of 1/sqrt(2), the minimalist patch attached could be
> > considered.
> >
> > Christophe
> >    
> 
> Patch ok.
> 

applied

Ben



More information about the ffmpeg-devel mailing list