[FFmpeg-devel] [RFC] libavfilter audio framework - split patches

Stefano Sabatini stefano.sabatini-lala
Sat Jul 17 13:06:32 CEST 2010


On date Wednesday 2010-07-14 16:41:51 +0200, Michael Niedermayer encoded:
> On Tue, Jul 13, 2010 at 01:39:01AM -0700, S.N. Hemanth Meenakshisundaram wrote:
> > S.N. Hemanth Meenakshisundaram wrote:
> >>> On date Sunday 2010-07-11 16:47:21 +0200, Michael Niedermayer encoded:
> >>>     
> >>>> On Sun, Jul 11, 2010 at 06:58:15AM -0700, S.N. Hemanth Meenakshisundaram
> >>>> wrote:
> >>>>       
> >>>>> S.N. Hemanth Meenakshisundaram wrote:
> >>>>>         [...]
> >>> OK I indeed have the same concerns. I see two ways for fixing this:
> >>> implementing some form of heiry macros, *or* generalize the code.
> >>>
> >>> Regards.
> >>> --
> >>>     
> >>
> >> Also attached are the new patches for generalization that go on top of
> >> existing libavfilter code before any audio stuff.
> >>
> >> First patch makes formats an int in the avfilter structures instead of
> >> enum PixelFormat.
> >>
> >> Second patch (on top of first) makes AVFilterPic into AVFilterBuffer,
> >> removes w and h from it, makes required code changes and makes the
> >> AVFilterBUffer's format field an int instead of PixelFormat.
> >>
> >> Regards,
> >>   
> >
> > This is part of the defaults.c patch. Makes free_video_buffer into 
> > free_buffer, so that it can be used for audio as well
> >
> 
> >  defaults.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 9d64bed86ca275fe69f02555db30f1fddb977481  free_buf.diff
> 
> this patch might be ok

Applied as part of the AVFilterPic -> AVFilterBuffer patch.

Regards.



More information about the ffmpeg-devel mailing list