[FFmpeg-devel] [RFC] libavfilter audio framework - split patches

[S.N. Hemanth Meenakshisundaram]

On 07/17/2010 12:28 PM, Michael Niedermayer wrote:
> On Sat, Jul 17, 2010 at 09:22:55PM +0200, Stefano Sabatini wrote:
>   
>> On date Friday 2010-07-16 01:01:39 -0700, S.N. Hemanth Meenakshisundaram encoded:
>>     
>>> On 07/16/2010 01:00 AM, S.N. Hemanth Meenakshisundaram wrote:
>>>       
>>>
>>> diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
>>> index c8db36f..50b558e 100644
>>> --- a/libavfilter/avfilter.h
>>> +++ b/libavfilter/avfilter.h
>>> @@ -71,7 +71,7 @@ typedef struct AVFilterBuffer
>>>  {
>>>      uint8_t *data[4];           ///< picture data for each plane
>>>      int linesize[4];            ///< number of bytes per line
>>> -    enum PixelFormat format;    ///< colorspace
>>> +    int format;                 ///< colorspace
>>>       
>> Update docs, that may say: colorspace or sample format
>>
>> Also I'm not very happy about the use of an int. What about something
>> like this:
>>
>> struct AVFilterBuffer
>> {
>>    enum AVMediaType type;
>>    ...
>>
>>    union {
>>        enum PixelFormat  video_format;
>>        enum SampleFormat audio_format;
>>     
>                                 ^^^^^^^
> unneeded?
>   

format is indeed unneeded in the AVFilterBuffer struct.
AVFilterSamplesref already has a sample_fmt field that is used in the
filters. However, AVFilterPicRef currently has no pix_fmt field. Also
vsrc_buffer and vf_overlay currently use this field in AVFilterBuffer.
These need to be patched before I can remove the format field in
AVFilterBuffer and add a pix_fmt to AVFilterPicRef struct.

Can I patch those filters?

Regards,
Hemanth