[FFmpeg-devel] [PATCH] Never shrink the buffer in ff_rewind_with_probe_data
Michael Niedermayer
michaelni
Sat Jul 24 04:05:02 CEST 2010
On Fri, Jul 23, 2010 at 11:49:05AM +0300, Martin Storsj? wrote:
> Hi,
>
> In ff_rewind_with_probe_data, if there is little unread data in the
> ByteIOContext buffer (e.g. when reading over a network where less data
> than requested may be returned in fill_buffer()), this may lead to
> reducing the size of the ByteIOContext buffer to little more the probe
> data size. This can lead to suboptimal aviobuf behaviour, e.g. making some
> demuxers fail to do short seeks backwards (if the input isn't seekable).
>
> This makes the mpegts demuxer work when probed over non-seekable http.
>
> // Martin
> aviobuf.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
> d000557ba399835e737cfd74989598ddbcadf5a0 0002-Never-shrink-the-buffer-in-ff_rewind_with_probe_data.patch
> From 41cfda5b9c2e10e2695537461252babd599e5b4f Mon Sep 17 00:00:00 2001
> From: Martin Storsjo <martin at martin.st>
> Date: Fri, 23 Jul 2010 10:56:31 +0300
> Subject: [PATCH 2/2] Never shrink the buffer in ff_rewind_with_probe_data
>
> If there is little unread data in the ByteIOContext buffer, this may lead
> to reducing the size of the ByteIOContext buffer to little more the probe
> data size. This can lead to suboptimal aviobuf behaviour, e.g. making some
> demuxers fail to do short seeks backwards (if the input isn't seekable).
might be ok if tested
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100724/b5c715ff/attachment.pgp>
More information about the ffmpeg-devel
mailing list