[FFmpeg-devel] [PATCH] libavcodec/wmavoice.c: local variable pow might mask pow function

Eli Friedman eli.friedman
Sun Jul 25 21:40:38 CEST 2010


On Sun, Jul 25, 2010 at 12:18 PM, Axel Holzinger <aholzinger at gmx.de> wrote:
> The issue is that a local variable pow masks a function pow and that
> hurts if powf - which is used in the scope of local variable pow - is
> not a function but a macro using double precision pow function.

And I'm pointing out that such an implementation is not correct per C99.

> Besides taking the effort to apply and document a patch, what do you
> think stands against the patch?

Simply that you haven't actually pointed to why this is necessary
other than the abstract possibility of a non-conforming implementation
of math.h.

-Eli



More information about the ffmpeg-devel mailing list