[FFmpeg-devel] [PATCH] Use more appropriate types when decoding vorbisfloats

Alex Converse alex.converse
Mon Jul 26 01:00:58 CEST 2010


On Sun, Jul 25, 2010 at 5:40 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Jul 25, 2010 at 03:41:08PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>>
>> > and LL is not wrong, it can be needed in expressions
>>
>> And L can't? ?I find that hard to believe.
>
> patcheck is a tool to show code that likely has issues not that certainly
> has issues.
>
>
>> Will you ban for loops
>> next time someone uses one incorrectly?
>
> will you stop trolling?
> patcheck and banning are 2 different things besides
> how many uses of <num>L in libav/ffmpeg are correct, how many wrong
> or at least unneeded?
>

It seems like a lot of the use of longs in general in FFmpeg are wrong
or unneeded. (See this particular case as an example) or look at
r24465. Why the hell did the original author decide to use long there?

--Alex



More information about the ffmpeg-devel mailing list