[FFmpeg-devel] [PATCH] Use more appropriate types when decoding vorbisfloats

[Måns Rullgård]

Rafa?l Carr? <rafael.carre at gmail.com> writes:

> On Sun, 25 Jul 2010 16:02:31 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
>
>> On Sun, Jul 25, 2010 at 03:09:14PM +0200, Rafa?l Carr? wrote:
>
>> > diff --git a/tools/patcheck b/tools/patcheck
>> > index de20500..cae25ab 100755
>> > --- a/tools/patcheck
>> > +++ b/tools/patcheck
>> > @@ -97,6 +97,7 @@ hiegrep ':\+[^}#]*else' 'missing } prior to else'
>> > $* #FIXME this should print the previous statement maybe
>> >  hiegrep ':\+  *{ *$' '{ should be on the same line as the related
>> > previous statement' $* 
>> > +hiegrep 'int.*[^0-9a-zA-Z_][0-9]+[Uu]?[Ll]?[Ll][^0-9a-zA-Z_]'
>> > 'possibly mixing int variable and long constant' $*
>> 
>> why int?
>
> i'm trying to match use of (unsigned) (long) long constants in
> expression involving int, such as:
>
> 	int i = 1L;
> 	int j = i * 345UL;
> 	random_type k = (int)var & 0x12345LL;
> 	long internal_buffer = 1L; // false positive

Use grep -E '\<int\>...' to avoid matching partial words.  In fact, the
'hiegrep' name suggests it's already using EREs.

-- 
M?ns Rullg?rd
mans at mansr.com