[FFmpeg-devel] [PATCH] Convert MMX deinterlacing code to YASM

Michael Niedermayer michaelni
Sat Jul 31 02:55:56 CEST 2010


On Fri, Jul 30, 2010 at 02:50:57PM +0200, Vitor Sessak wrote:
> On 07/29/2010 11:50 AM, Vitor Sessak wrote:
>> On 07/29/2010 01:00 AM, Michael Niedermayer wrote:
>>> On Thu, Jul 29, 2010 at 12:33:17AM +0200, Vitor Sessak wrote:
>>>> On 07/28/2010 11:56 PM, Michael Niedermayer wrote:
>>>>> On Wed, Jul 28, 2010 at 05:54:18PM +0200, Vitor Sessak wrote:
>>>>>> $subj, fixes the warning
>>>>>>
>>>>>>> In file included from
>>>>>>> /misc/fate/build/x86_32-linux-gcc-4.3/src/libavcodec/imgconvert.c:41:
>>>>>>> /misc/fate/build/x86_32-linux-gcc-4.3/src/libavcodec/x86/mmx.h:24:2:
>>>>>>> warning: #warning Everything in this header is deprecated, use plain
>>>>>>> __asm__()! New code using this header will be rejected.
>>>>>>
>>>>>> -Vitor
>>>>>
>>>>>> imgconvert.c | 99
>>>>>> +++++++---------------------------------------------
>>>>>> x86/deinterlace.asm | 81 ++++++++++++++++++++++++++++++++++++++++++
>>>>>> x86/dsputil_mmx.h | 13 ++++++
>>>>>
>>>>> That deinterlacer is deprecated, we have better code in libpostproc
>>>>> libmpcodecs and probably other places
>>>>
>>>> Anything LGPL and MMX optimized?
>>>
>>> The idea is to get some commercial company to donate money to the authors
>>> and our non profit to relicence to LGPL
>>
>> Since we know this can take some time (remember swscale), I think my
>> patch is useful to have cleaner code in the meantime.
>
> ping? I don't see how my patch gets in the way of getting a company to pay 
> for LGPL'ing yadif (companies don't care about ugly hacks as long as it 
> works).

it doesnt get into its way. its just deprecated code and as its also
uninterresting and that iam atm strugling to keep up with reviewing
patches to non deprecated code in the time available  ...
so youll have to apply without a review or find someone else to review


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100731/ae3387f1/attachment.pgp>



More information about the ffmpeg-devel mailing list