[FFmpeg-devel] [PATCH 1/2] Prettify eval.h doxy.

Michael Niedermayer michaelni
Thu Jun 3 01:32:47 CEST 2010


On Thu, Jun 03, 2010 at 12:35:21AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2010-06-02 00:44:34 +0200, Stefano Sabatini encoded:
> > On date Tuesday 2010-06-01 21:43:50 +0200, Michael Niedermayer encoded:
> > > On Tue, Jun 01, 2010 at 06:45:06PM +0200, Stefano Sabatini wrote:
> [...]
> > > > give clear
> > > > indications and I'll try to follow them, while trying to avoid overly
> > > > long lines at the same time.
> > > 
> > > with 1 line "things" the fact that each line is one "thing" provides
> > > adequate seperation
> > > with multiline "things" another form of seperation is needed or this becomes
> > > a bit spagethi like.
> > > the empty space in the first columns helps a bit but i think
> > > that maybe empty lines would help more
> > 
> > As you may guess I'm also concerned about the consistency with the
> > rest of the doxies, I don't want to end up with each file showing a
> > different style, so while I can tolerate long lines and vertical
> > @param alignment I'd prefer to avoid other forms of separation between
> > params seen nowhere else in the docs.
> > 
> > Anyway, since I don't want to waste more time on this, feel free to
> > fetch the patch, edit and apply it yourself, or just give me the OK
> > and I'll apply it as it is.
> 
> Another version of the bikeshed attached, that should hopefully make
> both Michael and me happy.
> 
> I'll apply the patch in few days unless there are other comments.

its still a unreadable spaethi mess, so i object
add empty lines of dont put a @param over more than 1 line

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100603/20c78eeb/attachment.pgp>



More information about the ffmpeg-devel mailing list