[FFmpeg-devel] [PATCH] Replace ASMALIGN() with .p2align

[Michael Niedermayer]

On Wed, Jun 02, 2010 at 07:46:41PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Wed, Jun 02, 2010 at 02:50:16PM +0100, Mans Rullgard wrote:
> >> The test for .align syntax was apparently unreliable with some compilers.
> >> Using the .p2align directive instead avoids the need for this test.
> >
> > why bruteforce replace all ASMALIGN by p2align ?
> 
> Keeping the macro seems like useless obfuscation.
> 
> > i think its safer, at least for the time being to rather define
> > it to p2align and only once we are sure all assemblers support
> > this drop all ASMALIGN() ?
> 
> Can anyone name an assembler that doesn't support it?  Remember that

i cant name one, but why did we use that macro in the first place if
p2align was supported and working in all cases?
i seem to faintly remember that someone said that no directive was supported
everywere but i could be misremembering


> this is only used for x86 inline asm, so only gnu-compatible
> compilers/assemblers need be considered.
> 
> That said, I'll happily do it in two steps.

i dont mind a single step if it works

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100603/2b676a88/attachment.pgp>