[FFmpeg-devel] [PATCH] RTP H.264 / AVC support

Howard Chu hyc
Thu Jun 3 13:21:59 CEST 2010

Luca Abeni wrote:
> Hi,
> On 06/03/2010 12:45 AM, Howard Chu wrote:
>> OK, I've taken your patch and moved a few things around and run it thru
>> patcheck. The only warning from it now is spurious (possibly unused var
>> which is definitely used).
> Ok; good to see that we are finally converging :)
> I do not like some of your changes to the sdp.c patch, but to find a
> tradeoff I think I can live with them.
> I'll split the h264_mp4toannexb_bsf.c part, and repost it for review;
> then, when it is accepted I'll commit the sdp.c part (after adding a
> check for "bsfc == NULL", which is still missing).

Sounds good.

> After that, we can move to the rtpenc* part (yesterday I tried my
> ff_avc_find_startcode_avc() idea, and I think it can allow to simplify
> the code a little bit).

Looking forward to that.

> In particular, I am still not sure about the
> need for the "NALP" data type.

Passing a single pointer to struct is cheaper than repeatedly passing 4 
arguments when the code is called frequently / in loops / in nested function 
calls / etc...
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

More information about the ffmpeg-devel mailing list