[FFmpeg-devel] [PATCH] libvpx: Disable frame dropping as rate control method

[Martin Storsjö]

On Sun, 6 Jun 2010, Reimar D?ffinger wrote:

> On Sun, Jun 06, 2010 at 11:31:26PM +0300, Martin Storsj? wrote:
> >   * trade-off is often acceptable, but for many applications is not.
> 
> Someone tried hard not disadvantage any option when they wronte this...
> 
> > I'm not particularly fond of this feature, I'd much rather get a bitrate 
> > slightly too high compared to suddenly getting half the framerate. The 
> > attached patch disables this in the libvpx wrapper - is this ok as 
> > default, or should it be changeable through some AVCodecContext field?
> 
> I think it's ok to leave disabled. Is the encoder even significantly better
> and making frame-drop decisions than an external application would be?
> (seems likely that yes, but still).

It doesn't feel like that in my tests at least - for some inputs, it 
simply starts dropping every second frame halfway through the clip, and 
keeps dropping every second one until the end. When I disabled this, the 
output bitrate didn't seem to change significantly at that spot where the 
dropping began either. So that's even less a reason for keeping it enabled 
by default...

// Martin