[FFmpeg-devel] [PATCH] mp4toannexb modification / improvement

[Luca Abeni]

On 08/06/10 20:52, Michael Niedermayer wrote:
[...]
>>> while it is quite obscure but the + could overflow and lead to a
>>> successfull allocation of a too small buffer
>>
>> Thanks for pointing this out... Would something like
>>      uint64_t extra_size = (uint64_t)icodec->extradata_size +
>> FF_INPUT_BUFFER_PADDING_SIZE;
>>      if (extra_size>  INT_MAX)
>>          goto fail;
>> be enough to fix the problem?
>
> yes

Applied, then. Now, back to the mp4toannexb BSF patch... I attach an 
improved version, which solves the extradata padding problem present in 
the previous version. Is it ok, or should I fix something?


			Thanks,
				Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improve_mp4toannexb_3.diff
Type: text/x-diff
Size: 2885 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100608/7b5b8920/attachment.diff>