[FFmpeg-devel] [PATCH] ARM: remove useless stack push/pop

[Måns Rullgård]

Rafa?l Carr? <rafael.carre at gmail.com> writes:

> On Wed, 09 Jun 2010 09:07:04 +0100
> M?ns Rullg?rd <mans at mansr.com> wrote:
>
>> >> > diff --git a/libavcodec/arm/jrevdct_arm.S
>> >
>> >> Does this function call any other functions?  If so, the stack must
>> >> maintain 8-byte alignment, and this is the easiest way to
>> >> accomplish that.  Not that you'd want to use that DCT
>> >> implementation anyway.
>> >
>> > No it doesn't (stack pointer is modified a few lines below entry
>> > anyway)
>> 
>> Does anything in the function require 8-byte alignment?  LDRD or so.
>
> No it's simple armv4, no fancy instructions.
>
> There was no 8-byte alignment anyway.

In that case patch OK.

-- 
M?ns Rullg?rd
mans at mansr.com