[FFmpeg-devel] A64 encoder

[Diego Biurrun]

On Mon, Jun 14, 2010 at 11:27:16AM +0200, Tobias Bindhammer wrote:
>
> I sent in my code for that encoder already back in 2009, but things got  
> stuck up in quite some discussions, that eventually let me drop my  
> interest on submitting. After a scene-mate talked to some of you guys at  
> the Linux-Tag recently about this encoder, Diego suggested me to just  
> send my patch again for submission.
>
> --- libavcodec/a64enc.h	(Revision 0)
> +++ libavcodec/a64enc.h	(Revision 0)
> @@ -0,0 +1,49 @@
> +
> +/**
> + * @file a64enc.h

The filename is redundant and harmful there.

> +} A64Context;
> +#endif /* AVCODEC_A64ENC_H */

An empty line before the #endif would make this look less cramped.

> --- libavcodec/a64tables.h	(Revision 0)
> +++ libavcodec/a64tables.h	(Revision 0)
> @@ -0,0 +1,91 @@
> +
> +/**
> + * @file a64tables.h

see above

> +     {1, 1, 1, 1},
> +     {1, 1, 1, 1}
> +     },
> +};
> +#endif /* AVCODEC_A64TABLES_H */

ditto

> --- doc/general.texi	(Revision 23561)
> +++ doc/general.texi	(Arbeitskopie)
> @@ -307,6 +307,8 @@
>  
>  @multitable @columnfractions .4 .1 .1 .4
>  @item Name @tab Encoding @tab Decoding @tab Comments
> + at item A64 multicolor         @tab  X  @tab
> +    @tab Creates video suitable to be played on a commodore 64 (multicolor mode).
>  @item 4X Movie               @tab     @tab  X
>      @tab Used in certain computer games.
>  @item 8088flex TMV           @tab     @tab  X

Didn't you add three different things?

Diego