[FFmpeg-devel] [PATCH] Fix segfault in x11grab when drawing Cursor on Xservers that don't support the XFixes extension

Brenden Bain brenden.bain
Tue Jun 22 00:40:36 CEST 2010


In r20631 x11grab.c was changed to query the current cursor from the
Xserver using the XFixes extension. This caused ffmpeg to segfault on
x11grab.c:265 when connected to a server that does not support this
extension (e.g. the VNC server).

In versions prior to r20631 ffmpeg used to just draw a static "arrow"
cursor. The fix basically brings back this code into x11grab.c and
uses it when the Xserver does not support XFixes.

The user will get a info message of the form "Unable to query cursor
shape. Using fixed mouse cursor." when ffmpeg is connected to a
Xserver without XFixes.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: x11grab.patch
Type: text/x-patch
Size: 7748 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100622/3a96858a/attachment.bin>

More information about the ffmpeg-devel mailing list