[FFmpeg-devel] [PATCH] Fix segfault in x11grab when drawing Cursor on Xservers that don't support the XFixes extension

Carl Eugen Hoyos cehoyos
Tue Jun 22 00:58:45 CEST 2010


Brenden Bain <brenden.bain <at> gmail.com> writes:

> In r20631 x11grab.c was changed to query the current cursor from the
> Xserver using the XFixes extension. This caused ffmpeg to segfault on
> x11grab.c:265 when connected to a server that does not support this
> extension (e.g. the VNC server).

Is this related to issue 1997?

[...]

> +    static const uint16_t const mousePointerBlack[] =
> +        {
> +            0x0000, 0x0003, 0x0005, 0x0009, 0x0011,

Indentation looks wrong.

[...]

> -    xcim = XFixesGetCursorImage(dpy);;
> +    xcim = XFixesGetCursorImage(dpy);

Applied this hunk, Carl Eugen




More information about the ffmpeg-devel mailing list