[FFmpeg-devel] [PATCH 03/12] mdct: remove temporary array in ff_kbd_window_init()

[Luca Barbato]

On 06/24/2010 02:35 AM, M?ns Rullg?rd wrote:
> Using malloc complicates error handling though.  The function
> currently returns no status (since it cannot fail), and the callers
> obviously do not check it.
> 
> Since allocating a 1024-element array is fine now, it should be OK
> even if hardcoded.  Do you forsee larger sizes being required in the
> future?

The users so far are aac and ac3 maybe switching to malloc isn't that
bad, it's a cold function so _maybe_ the vla isn't that problematic.

btw why that function is 3 space indented?

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero