[FFmpeg-devel] [PATCH 03/12] mdct: remove temporary array in ff_kbd_window_init()

Måns Rullgård mans
Thu Jun 24 15:17:25 CEST 2010

Luca Barbato <lu_zero at gentoo.org> writes:

> On 06/24/2010 02:35 AM, M?ns Rullg?rd wrote:
>> Using malloc complicates error handling though.  The function
>> currently returns no status (since it cannot fail), and the callers
>> obviously do not check it.
>> Since allocating a 1024-element array is fine now, it should be OK
>> even if hardcoded.  Do you forsee larger sizes being required in the
>> future?
> The users so far are aac and ac3 maybe switching to malloc isn't that
> bad, it's a cold function so _maybe_ the vla isn't that problematic.

I'm trying to obliterate _all_ VLAs so I can make them an error to
avoid really nasty ones creeping in.  It seems that my shouting about
their badness from time to time isn't enough to keep them at bay.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list