[FFmpeg-devel] [PATCH] R10k deocder

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Sat, Jun 26, 2010 at 08:59:03PM +0100, M?ns Rullg?rd wrote:
>> "Zhou Zongyi"<zhouzy at os.pku.edu.cn> writes:
>> > +    } 
>> > + 
>> > +    pic->reference = 0; 
>> > +    if (avctx->get_buffer(avctx, pic) < 0) 
>> > +        return -1; 
>> 
>> Propagating the error code back to the caller would be nice.
>
> Almost all codecs do it this way currently, it probably
> would make sense to change all then.

Yes, I think it would.

> I guess the reason for this is that the return value of
> get_buffer isn't documented anywhere, so I at least was
> not sure if we can assume FFmpeg-style error codes (though
> I guess it is the only way that makes sense).

If the app overrides get_buffer, it probably knows what error codes it
returns too.

-- 
M?ns Rullg?rd
mans at mansr.com