[FFmpeg-devel] [PATCH] Fix strict-aliasing violations in MPV_motion_internal (in mpegvideo_common.h)

Michael Niedermayer michaelni
Tue Jun 29 23:54:17 CEST 2010


On Tue, Jun 29, 2010 at 02:07:20PM -0700, Eli Friedman wrote:
> Patch attached.  Per subject, fixes strict-aliasing violations.  I
> have absolutely no clue why, but gcc 4.4 actually generates slightly
> different code, but not in any way directly related to the change (the
> patched version uses "add    %r13d,%eax" instead of "lea
> 0x0(%r13,%rax,1),%eax" in a few places in mpegvideo.c, and the
> register allocation is different in mpegvideo_enc.c).
> 
> -Eli

> Index: libavcodec/mpegvideo_common.h
> ===================================================================
> --- libavcodec/mpegvideo_common.h	(revision 23854)
> +++ libavcodec/mpegvideo_common.h	(working copy)

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100629/ab9c570f/attachment.pgp>



More information about the ffmpeg-devel mailing list