[FFmpeg-devel] [PATCH 05/28] support seeking in nuv files

[elupus]

On Wed, 30 Jun 2010 20:10:09 +0200, Reimar D?ffinger wrote:

>>| On the note of AVFMT_GENERIC_INDEX, that only works if the stream is set to
>>| require parsing. Non parsed packets are not considered. Even if they have
>>| PKT_FLAG_KEY set.
> 
> 
> You mean like:
> ------------------------------------------------------------------------
> r17965 | reimar | 2009-03-14 22:46:00 +0100 (Sat, 14 Mar 2009) | 2 lines
> 
> Add AVFMT_GENERIC_INDEX support also for formats that do not use a parser.
> 
> ------------------------------------------------------------------------

Hehe, yea just like that. Passed by without me remembering about this
patch. 

>> 
>>| Also too speed up seeks using av_seek_frame_binary, I added index entries
>>| when a timestamp is found using read_timestamp. However wouldn't it be
>>| better to add this to av_seek_frame_binary? perhaps only when
>>| AVFMT_GENERIC_INDEX is set in format.
>> 
>> 
>> If i remember correctly it made quite a difference.
> 
> Nobody ever gave me a sample to actually test though :-)

By the looks of it, i have one singular NUV sample left. I have no idea if
that is what i used back in the days. 

> Could you please test attached patch?

Will try to.