[FFmpeg-devel] [RESEND][PATCH] libswscale: Extend the?unaccelerated path of the unscaled yuv2rgb special converter with?support for rgb444 output format

Janusz Krzysztofik jkrzyszt
Tue Mar 2 14:50:05 CET 2010


Tuesday 02 March 2010 13:57:56 Michael Niedermayer napisa?(a):
> On Tue, Mar 02, 2010 at 01:41:50PM +0100, Janusz Krzysztofik wrote:
> > Tuesday 02 March 2010 12:56:14 Michael Niedermayer wrote:
> > > On Mon, Mar 01, 2010 at 02:09:56AM +0100, Janusz Krzysztofik wrote:
>
> [...]
>
> > > also it seems dithering is missing
> >
> > To be sure: you didn't mean it's missing from the unscaled yuv2rgb
> > special converter rgb444 output format support I'm trying to provide with
> > this patch, did you?
>
> i think it would look better with dithering

Forgive me my ignorance: does it mean I shouldn't use existing yuv2rgb_c_16() 
function for rgb444 but rather create a new one, like yuv2rgb_c_12_dither(), 
possibly derieving it from yuv2rgb_c_8_ordered_dither(), with its specific 
PUTRGB12() macro derieved form PUTRGB8()? Then, would it also be necessary to 
correct my code for rgb444 c->yuvTable initialization in 
ff_yuv2rgb_c_init_tables()?

Thanks,
Janusz



More information about the ffmpeg-devel mailing list