[FFmpeg-devel] [PATCH] pixel aspect ratio

Carl Eugen Hoyos cehoyos
Tue Mar 2 23:27:58 CET 2010


VolodyA! V Anarhist <Volodya <at> WhenGendarmeSleeps.org> writes:

> The code is pretty trivial and for the most part copies what happens in 
> opt_frame_aspect_ratio().

Just a few cosmetic comments.
Your patch contains trailing whitespace and tabs, both cannot be committed to
FFmpeg svn.
The maintainer prefers
if (A) {
    B();
    C();
} else {
    D()
}
(Note the additional braces..)
tools/patcheck should have told you all this.
It's probably not necessary to send an updated patch before you get a true
review.

Carl Eugen




More information about the ffmpeg-devel mailing list