[FFmpeg-devel] Patch to fix qtrle endian issue with rgb555 pixel format

Alexis Ballier alexis.ballier
Thu Mar 4 01:13:24 CET 2010


2010/3/3 Michael Niedermayer <michaelni at gmx.at>:
[...]
>> > fix swscale, if swscale is lacking support.
>>
>> I did send a patch for exactly this purpose some time ago [1]... my
>> understanding was that it was rejected because:
>> - you didnt care about non native endian formats
>> - the fastest version increased too much the code/object size
>> - I didn't want to submit a patch that was obviously suboptimal in
>> terms of speed
>
> to me it felt like you just run away in the middle of review

that is true too because I didn't have a solution

> anyway, what has apparently been missed in the old thread is that
> the c converter can be implemented purly by changing the yuv2rgb tables
> without touching the inner loops.
> this should be optimal in your definition as well, so i expect a new
> patch from you :)

Yep, that works great, thanks.

Alexis.



More information about the ffmpeg-devel mailing list