[FFmpeg-devel] [PATCH] Add AV_CONFIG_* for libav* libs to libavutil/avconfig.h

Michael Niedermayer michaelni
Sat Mar 6 02:04:26 CET 2010


On Sat, Mar 06, 2010 at 12:07:16AM +0000, M?ns Rullg?rd wrote:
[...]
> The ff* apps are in a special situation in that they are considered
> external to the libav* libraries, and thus must use only public the
> API, while still sharing configure script and makefiles.  This is not
> a problem at all in my opinion.  The config.h file we create does in
> no way depend on internals of the libraries.  It is therefor not wrong
> of ffmpeg.c et al to #include config.h.  If they were built separately
> from the libs, there would still be a configure script creating a very
> similar config.h.
> 
> What we should _not_ be doing is defining HAVE_AV_CONFIG_H when
> compiling ffmpeg.c.  That would expose internals which we should not
> be touching.

indeed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100306/daf11615/attachment.pgp>



More information about the ffmpeg-devel mailing list